Fix #8020: Create dotty-tasty-inspector library #8021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#8020
branch
4 times, most recently
from
7bfbd64 to
e34a01f
Compare
|
What's the benefit of having an extra library instead of having this stuff in dotty-compiler ? |
|
Same as in |
smarter
reviewed
Jan 17, 2020
smarter
reviewed
Jan 17, 2020
smarter
reviewed
Jan 17, 2020
|
To make things simpler we could fusion dotty-staging and dotty-tasty-consumer then. |
|
|
nicolasstucki
force-pushed
the
fix-#8020
branch
3 times, most recently
from
c814ac9 to
9485a20
Compare
nicolasstucki
requested review from
smarter
and removed request for
liufengyun
smarter
previously requested changes
Jan 22, 2020
nicolasstucki
force-pushed
the
fix-#8020
branch
from
9485a20 to
6185481
Compare
|
I'm considering renaming it |
nicolasstucki
force-pushed
the
fix-#8020
branch
2 times, most recently
from
fe1f9ad to
486c184
Compare
Also rework TastyInspector API to simplify use.
nicolasstucki
force-pushed
the
fix-#8020
branch
from
486c184 to
83fc85a
Compare
nicolasstucki
changed the title
smarter
approved these changes
Jan 30, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeats the changes in #7080 for
dotty-tasty-inspector.Extract the tasty-consumer out of the standard library and compiler.
dotty-tasty-inspectorproject that depends ondotty-compilerdotty-tasty-inspectorproject or jartasty.file.{ConsumeTasty, TastyConsumer},TastyConsumerPhase, andTastyFromClassintodotty-tasty-inspectorasTastyInspectorConsumeTasty.applydirectly (instead of as a java reflection call) asTastyInspector.inspect"ch.epfl.lamp" %% "dotty-tasty-inspector" % scalaVersion.valuedotty.tools.dotc.util.ClasspathFromClassloadercore logic fordotty-staginganddotty-tasty-consumertastdoctests on CI (mostly to check it compiles)